I prefer the 12-24 because its range is more useful. I think 16mm for stars are probably too wide and for general purpose the extra zoom is more useful than F2.8.
Both lenses have reasonably good image quality and they should work nicely with a D90. The only thing you should check is whether your friend has any plan to upgrade to FF as these 2 lenses are DX.